[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.1.10.0904280015040.15450@vinegar-pot.mit.edu>
Date: Tue, 28 Apr 2009 00:20:47 -0400 (EDT)
From: Tim Abbott <tabbott@....EDU>
To: Sam Ravnborg <sam@...nborg.org>
cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Linux kernel mailing list <linux-kernel@...r.kernel.org>,
Anders Kaseorg <andersk@....edu>,
Waseem Daher <wdaher@....edu>,
Denys Vlasenko <vda.linux@...glemail.com>,
Jeff Arnold <jbarnold@....edu>,
Paul Mundt <lethal@...ux-sh.org>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned
section.
On Mon, 27 Apr 2009, Tim Abbott wrote:
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -222,6 +222,7 @@ SECTIONS
>
> #ifdef CONFIG_PPC32
> .data : AT(ADDR(.data) - LOAD_OFFSET) {
> + PAGE_ALIGNED_DATA
> DATA_DATA
> *(.sdata)
> *(.got.plt) *(.got)
Just noticed that PAGE_ALIGNED_DATA is only being added for CONFIG_PPC32.
Since there will be several more FOO_DATA macros being added to the .data
section, I think the right fix is to first unify the two .data output
section definitions, and then convert to using PAGE_ALIGNED_DATA.
-Tim Abbott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists