linux-kernel - Re: [PATCH 2/3] tracing/filters: distinguish between signed and unsigned fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090429103655.GD2373@elte.hu>
Date:	Wed, 29 Apr 2009 12:36:55 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Tom Zanussi <tzanussi@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>, fweisbec@...il.com,
	Li Zefan <lizf@...fujitsu.com>
Subject: Re: [PATCH 2/3] tracing/filters: distinguish between signed and
	unsigned fields


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Tue, 28 Apr 2009 03:04:53 -0500 Tom Zanussi <tzanussi@...il.com> wrote:
> 
> > +#define is_signed(t)	(((t)-1) < 0)
> 
> geeze that was confusing until I worked out that `t' is supposed to be
> the name of a C type.

good point, i've changed its name to is_signed_type().

> 	is_signed(0) == true!
> 
> whee.

I also added parantheses around the -1 literal to make it clear that 
this is a cast.

> Rename it to is_signed_type() or something, please?

done.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/