| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090429124719.19278.51952.stgit@warthog.procyon.org.uk> Date: Wed, 29 Apr 2009 13:47:19 +0100 From: David Howells <dhowells@...hat.com> To: linux-security-module@...r.kernel.org, jmorris@...ei.org Cc: dhowells@...hat.com, oleg@...hat.com, linux-kernel@...r.kernel.org Subject: [PATCH] SELinux: Remove excessive interrupt disablement There's no need to disable interrupts with spin_lock_irqsave() inside of read_lock_irq(). Signed-off-by: David Howells <dhowells@...hat.com> --- security/selinux/hooks.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index ba808ef..0702ba6 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -2378,7 +2378,6 @@ static void selinux_bprm_committed_creds(struct linux_binprm *bprm) struct sighand_struct *psig; u32 osid, sid; int rc, i; - unsigned long flags; osid = tsec->osid; sid = tsec->sid; @@ -2410,9 +2409,9 @@ static void selinux_bprm_committed_creds(struct linux_binprm *bprm) * wait permission to the new task SID. */ read_lock_irq(&tasklist_lock); psig = current->parent->sighand; - spin_lock_irqsave(&psig->siglock, flags); + spin_lock(&psig->siglock); wake_up_interruptible(¤t->parent->signal->wait_chldexit); - spin_unlock_irqrestore(&psig->siglock, flags); + spin_unlock(&psig->siglock); read_unlock_irq(&tasklist_lock); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists