[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090429131817.GB17254@gondor.apana.org.au>
Date: Wed, 29 Apr 2009 21:18:17 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Jarod Wilson <jarod@...hat.com>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH] crypto: print self-test pass notices in fips mode
On Tue, Apr 28, 2009 at 09:21:35PM -0400, Jarod Wilson wrote:
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index 39ffa69..d0cc85c 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -2149,6 +2149,10 @@ notest:
> test_done:
> if (fips_enabled && rc)
> panic("%s: %s alg self test failed in fips mode!\n", driver, alg);
> + /* fips mode requires we print out self-test success notices */
> + if (fips_enabled && !rc && strncmp(alg, "ctr(aes", 7))
> + printk(KERN_INFO "alg: self-tests for %s (%s) passed\n",
> + driver, alg);
What is this strncmp crap for?
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists