linux-kernel - [PATCH] x86: x86_32 kdump boot on cpu != 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1241042172.13036.9.camel@localhost.localdomain>
Date:	Wed, 29 Apr 2009 14:56:12 -0700
From:	Ed Swierk <eswierk@...stanetworks.com>
To:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] x86: x86_32 kdump boot on cpu != 0

Booting an x86_32 SMP kernel via kdump fails if the boot CPU has local
APIC ID != 0, with a panic:

  Boot APIC ID in local APIC unexpected (1 vs 0)

MP_processor_info() sets boot_cpu_physical_apicid to 0 based on the
mptable.  But this variable needs to be set to 1 later on to reflect the
actual local APIC ID.  (Setting it to 1 right off the bat causes
generic_processor_info() to complain about an "apic version mismatch",
which I don't understand.)

This change restores the apic_64.c logic, which existed prior to the
merge with apic_32.c, and allows the kdump kernel to boot.
 
Signed-off-by: Ed Swierk <eswierk@...stanetworks.com>
---
 arch/x86/kernel/apic/apic.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index f287092..b45c764 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1563,8 +1563,7 @@ void __init init_apic_mappings(void)
 	 * Fetch the APIC ID of the BSP in case we have a
 	 * default configuration (or the MP table is broken).
 	 */
-	if (boot_cpu_physical_apicid == -1U)
-		boot_cpu_physical_apicid = read_apic_id();
+	boot_cpu_physical_apicid = read_apic_id();
 }
 
 /*


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/