linux-kernel - Re: [PATCH 2/5] USB: Provide USB boot device availability notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49F9C8E0.30808@ru.mvista.com>
Date:	Thu, 30 Apr 2009 19:50:56 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	David VomLehn <dvomlehn@...co.com>, linux-usb@...r.kernel.org,
	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] USB: Provide USB boot device availability notification

Alan Stern wrote:

>>>+/* The mask of possible USB boot devices depends on what drivers and
>>>+ * options have been configured into the kernel.  There are too many
>>>+ * USB network config options to list here, so just assume it is always
>>>+ * possible to have a USB network device.
>>>+ */
>>>+static int usb_bootdev_mask = 0
>>>+#ifdef CONFIG_USB_SERIAL_CONSOLE
>>>+				| BOOTDEV_CONSOLE_MASK
>>>+#endif
>>>+#if defined(CONFIG_USB_STORAGE) | defined(CONFIG_BLK_DEV_UB)

>>    It should be ||, not bitwise | here, no?

> No, it should be bitwise |.  The value being constructed is a union of 
> disjoint mask bits.

    I meant the #if line only. Although it shouldn't matter really...

> Alan Stern

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/