linux-kernel - Re: [PATCH] asus_atk0110: fix compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090430190101.7a46f082@hyperion.delvare>
Date:	Thu, 30 Apr 2009 19:01:01 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Luca Tettamanti <kronos.it@...il.com>
Cc:	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: [PATCH] asus_atk0110: fix compiler warning

Hi Luca,

On Wed, 29 Apr 2009 21:22:55 +0200, Luca Tettamanti wrote:
> atk_sensor_type is only used when DEBUG is defined.
> 
> Signed-off-by: Luca Tettamanti <kronos.it@...il.com>
> 
> ---
> Jean can you pick this up?
> 
>  drivers/hwmon/asus_atk0110.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
> index 0897ede..bff0103 100644
> --- a/drivers/hwmon/asus_atk0110.c
> +++ b/drivers/hwmon/asus_atk0110.c
> @@ -348,6 +348,7 @@ static int validate_hwmon_pack(struct atk_data *data, union acpi_object *obj)
>  	return 0;
>  }
>  
> +#ifdef DEBUG
>  static char const *atk_sensor_type(union acpi_object *flags)
>  {
>  	u64 type = flags->integer.value & ATK_TYPE_MASK;
> @@ -370,6 +371,7 @@ static char const *atk_sensor_type(union acpi_object *flags)
>  
>  	return what;
>  }
> +#endif
>  
>  static void atk_print_sensor(struct atk_data *data, union acpi_object *obj)
>  {

Thanks for the fix, I've just applied it.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/