linux-kernel - Re: [PATCH] virtio: add missing include to virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40904291820q9019708oaa737c6d8f65ca02@mail.gmail.com>
Date:	Wed, 29 Apr 2009 19:20:38 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	rusty@...tcorp.com.au
Subject: Re: [PATCH] virtio: add missing include to virtio_net.h

On Wed, Apr 29, 2009 at 6:49 PM, David Miller <davem@...emloft.net> wrote:
> From: Grant Likely <grant.likely@...retlab.ca>
> Date: Tue, 28 Apr 2009 09:46:54 -0600
>
> [ Grant, please CC: netdev on networking patches, thanks. ]

Oops, sorry about that; I had in my head "virtio" and it didn't even
occur to me that it was also netdev.  :-)

g.

>
>> virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
>> Discovered when hacking on virtio-over-pci patches.
>>
>> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
>
> Rusty, ACK?
>
> I haven't been able to get responses from Rusty on virtio net
> patches, so if he doesn't start responding soon I'm going to
> integrates the fixes I've seen lately as they all look
> reasonable to me.
>
>> ---
>>
>>  include/linux/virtio_net.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>>
>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
>> index 242348b..cec79ad 100644
>> --- a/include/linux/virtio_net.h
>> +++ b/include/linux/virtio_net.h
>> @@ -4,6 +4,7 @@
>>   * compatible drivers/servers. */
>>  #include <linux/types.h>
>>  #include <linux/virtio_config.h>
>> +#include <linux/if_ether.h>
>>
>>  /* The ID for virtio_net */
>>  #define VIRTIO_ID_NET        1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/