linux-kernel - in_suspend and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090430203000.GA10999@uranus.ravnborg.org>
Date:	Thu, 30 Apr 2009 22:30:00 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Tim Abbott <tabbott@....EDU>
Subject: in_suspend and __nosave

Hi Rafael & Linus.

While unifying vmlinux.lds for x86 I stumbled
over the .data.nosave section.

Searching a bit I found only a single user:

swsusp.c:int in_suspend __nosavedata = 0;

Do we really needs all this complexity for this single integer?
We have this section defined in several arch lds files.

I understand that in_suspend is special as in that we do not
want the value restored while resuming.
But is there no other way to do so today?

All I want is to kill a lot from the vmlinux.lds files.

It also occur to me that only: x86, powerpc, and sh
implement pfn_is_nosave() which I think is the only
place where we decide if we want to save a page or not.

But we define the .data.nosave section in following
architectures:
arm, m32r, mips, mn10300, parisc, s390 in addition
to the above archs that define pfn_is_nosave().
Is this something to be cleaned up?

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/