linux-kernel - Re: usbutils 0.81 release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac3eb2510904291906v6b8524f7j5cb3afa43f6759b8@mail.gmail.com>
Date:	Thu, 30 Apr 2009 04:06:53 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	Greg KH <greg@...ah.com>, Valdis.Kletnieks@...edu,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: usbutils 0.81 release

On Thu, Apr 30, 2009 at 03:56, Mike Frysinger <vapier.adi@...il.com> wrote:
> On Wed, Apr 29, 2009 at 21:48, Kay Sievers wrote:
>> On Wed, 2009-04-29 at 14:56 -0700, Greg KH wrote:
>>> If youreally want it, you can grab it from the git tree, or wait a day
>>> or so for me to implement Mike's changes he so nicely sent me, so I can
>>> do a new release.
>>
>> How about this? It substitutes the script and the man page with the
>> given --datadir=.
>
> i had pretty much the same changes locally, but i was going to let the
> discussion on data/multiple paths finish first.  at any rate, comments
> below ...
>
>> --- a/Makefile.am
>> +++ b/Makefile.am
>>
>> +update-usbids.sh: update-usbids.sh.in
>> +lsusb.8: lsusb.8.in
>
> need $(srcdir)/ in front of the dependency
>
>> +       sed 's|@...ids@|$(datadir)/usb.ids|' $< >$@
>> +       sed 's|@...ids@|$(datadir)/usb.ids|' $< >$@
>
> should use the 'g' option to sed
>
> in theory you should use AC_PROG_SED in configure.ac and then $(SED)
> in the Makefile.am

Fine, if that works.

> $(datadir) too should die ... $(datarootdir) is the right variable name

Then you want to specify man pages separately? I wouldn't do that.

>>  clean-local:
>>        rm -f usb.ids.gz
>> +       rm -f lsusb.8
>> +       rm -f update-usbids.sh
>
> after Greg merges the patches i sent for usb.ids.gz, it should be
> clear that clean-local should die and you should update DISTCLEANFILES

Sure, no problem.

>> --- a/configure.ac
>> +++ b/configure.ac
>>
>> +       datadir:                ${datadir}
>
> we have datarootdir now, so no point in adding datadir

Only if you require to set the man dir.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/