linux-kernel - Re: [PATCH] Detect and warn on atomic_inc/atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090430220648.268ab9bb.akpm@linux-foundation.org>
Date:	Thu, 30 Apr 2009 22:06:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Nikanth Karthikesan <knikanth@...ell.com>
Cc:	mingo@...e.hu, jens.axboe@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Detect and warn on atomic_inc/atomic_dec wrapping
 around

On Fri, 1 May 2009 10:27:46 +0530 Nikanth Karthikesan <knikanth@...ell.com> wrote:

> I tried with linux/bug.h. But it creates a cyclic dependency. linux/bug.h 
> pulls in linux/module.h => linux/spinlock.h => asm/spinlock.h (which uses 
> atomic_inc) => asm/atomic.h,.

And why on earth does bug.h need module.h?

int  module_bug_finalize(const Elf_Ehdr *, const Elf_Shdr *,
			 struct module *);

The ever-smelly Elf_Ehdr and Elf_Shdr.

Probably the module_bug_finalize/module_bug_cleanup declarations and
definitions should be in module.h.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/