linux-kernel - Re: Probe Timeouts with 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1241165805.13562.2.camel@johannes.local>
Date:	Fri, 01 May 2009 10:16:45 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Parag Warudkar <parag.lkml@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, niel.lambrechts@...il.com
Subject: Re: Probe Timeouts with 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8

Parag,

> Niel bisected the probe timeouts with iwlagn to your commit
> 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8 .  I too was getting probe
> timeouts but with ath9k and tried reverting the above commit which
> made the problem disappear.

I know. There's a bug in that commit.

> It is not yet reverted from mainline and compat-wireless - just wanted
> to bring it to your notice that it impacts both iwlagn and ath9k.

I'm not sure what makes you think that it even _should_ be reverted.
Just to make that clear: it should _not_ be reverted. How did you check
that it isn't reverted in compat-wireless anyway? Must have been by code
inspection since if you had made an attempt to verify that the code in
there works, you would have found that indeed there's no reason to
revert this commit since the fix for it went in, and is literally a
single line.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)