linux-kernel - Re: [PATCH 17/27] add generic lib/checksum.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49FABF8C.7000505@monstr.eu>
Date:	Fri, 01 May 2009 11:23:24 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org,
	Michal Simek <monstr@...str.eu>,
	Remis Lima Baima <remis.developer@...glemail.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/27] add generic lib/checksum.c

Russell King wrote:
> On Tue, Mar 31, 2009 at 03:30:31PM +0200, Arnd Bergmann wrote:
>> +/*
>> + * copy from fs while checksumming, otherwise like csum_partial
>> + */
>> +__wsum
>> +csum_partial_copy_from_user(const void __user *src, void *dst, int len,
>> +						__wsum sum, int *csum_err)
>> +{
>> +	if (csum_err)
>> +		*csum_err = 0;
>> +	memcpy(dst, src, len);
> 
> Since when has 'memcpy' been valid from user addresses?
> 
yes, that's wrong

copy_from_user(dst, src, len);

should be there

Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/