linux-kernel - Re: [PATCH 07/27] asm-generic: add minimal cache description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49FAF074.9080202@monstr.eu>
Date:	Fri, 01 May 2009 14:52:04 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Arnd Bergmann <arnd@...db.de>
CC:	linux-arch@...r.kernel.org,
	Remis Lima Baima <remis.developer@...glemail.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/27] asm-generic: add minimal cache description

Arnd Bergmann wrote:
> On Friday 01 May 2009, Michal Simek wrote:
>>> +#define copy_to_user_page(vma, page, vaddr, dst, src, len) \
>>> +       memcpy(dst, src, len)
>>> +#define copy_from_user_page(vma, page, vaddr, dst, src, len) \
>>> +       memcpy(dst, src, len)
>>
>> IMHO these two macros will generate cast errors.
> 
> I did not see errors here, can you clarify? Note that despite the name,
> they don't take a __user pointer. Maybe they should be inline functions
> to make that more obvious.

you are right here with __user.
x86 use it as inline function.

Michal

> 
> 	Arnd <><


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/