linux-kernel - Re: [PATCH 04/27] asm-generic: add legacy I/O header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090501141414.4adfe4ab@lxorguk.ukuu.org.uk>
Date:	Fri, 1 May 2009 14:14:14 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Russell King <rmk+lkml@....linux.org.uk>,
	Michal Simek <monstr@...str.eu>, linux-arch@...r.kernel.org,
	Remis Lima Baima <remis.developer@...glemail.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/27] asm-generic: add legacy I/O header files

> #ifndef CLOCK_TICK_RATE
> #define CLOCK_TICK_RATE                1193182
> #endif
> 
> to include/linux/timex.h. Since al existing architectures already define
> CLOCK_TICK_RATE as a macro, I don't see anything changing for them.
> 
> The only difference would be that all architectures that use the default
> value can have an empty timex.h.
> 
> Am I missing something?

Currently if you create a new architecture you have to figure out what
your equivalent tick rate is or you get an error for not defining it.
Ditto if you try to build code using it on platforms that it is
meaningless (eg S/390) you get an error.

You'd lose that rather useful property.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/