linux-kernel - Re: [PATCH 1/2] ftrace: add notrace to ARM sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0905011942390.20374@gandalf.stny.rr.com>
Date:	Fri, 1 May 2009 19:43:50 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	Tim Bird <tim.bird@...sony.com>,
	linux kernel <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.arm.linux.org.uk>,
	Ingo Molnar <mingo@...e.hu>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Russell King <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH 1/2]  ftrace: add notrace to ARM sched_clock routines


On Sat, 2 May 2009, Frederic Weisbecker wrote:
> >  }
> > @@ -203,7 +203,7 @@ static struct clocksource clocksource_32
> >   * Returns current time from boot in nsecs. It's OK for this to wrap
> >   * around for now, as it's just a relative time stamp.
> >   */
> > -unsigned long long sched_clock(void)
> > +unsigned long long notrace sched_clock(void)
> >  {
> >  	unsigned long long ret;
> 
> 
> I've looked into all of these functions and they don't seem to call
> anything that could be traced. I could have missed something though
> but it looks good.

I think the issue is that the tracing clock will call these functions, and 
we will waste time recursing into them.

> 
> Acked-by: Frederic Weisbecker <fweisbec@...il.com>

Heck I'll add mine too ;-)

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/