linux-kernel - Re: [BUG] 2.6.30-rc4 hid bluetooth not working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 02 May 2009 10:45:41 +0200
From:	"Marc Pignat" <Marc.Pignat@...s.ch>
To:	<marcel@...tmann.org>, <jkosina@...e.cz>
Cc:	<ext-roger.quadros@...ia.com>, <linux-bluetooth@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [BUG] 2.6.30-rc4 hid bluetooth not working

>>> Marcel Holtmann <marcel@...tmann.org> 05/02/09 12:57 AM >>>
>Hi Jiri,
>
>> > Subject: bluetooth: Fix serialization when adding/deleting connections in hci_sysfs
>> > 
>> > add_conn and del_conn should be serialized, but flush_workqueue can't be used
>> > by the worker thread on it's own queue, so use flush_work to serialize add_conn
>> > and del_conn against each other.
>> > 
>> > Signed-off-by: Marc Pignat <marc.pignat@...s.ch>
>> 
>> Acked-by: Jiri Kosina <jkosina@...e.cz>
>> 
>> FWIW.
>
>nak from my side since I think it is the wrong fix. We really wanna wait
>for all works to finish here. This includes work from other connection
>attempts or terminations.

IMHO, there is no need to wait for work currently running, since this is a
singlethread workqueue.

But it is perhaps simpler to use a lock (mutex or watherver locking primitive).

Regards

Marc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/