linux-kernel - Re: [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87skjn94no.fsf@devron.myhome.or.jp>
Date:	Sat, 02 May 2009 19:32:11 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	tridge@...ba.org
Cc:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	Steve French <sfrench@...ibm.com>,
	Mingming Cao <cmm@...ibm.com>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES option

tridge@...ba.org writes:

> OGAWA Hirofumi writes:
>  > I'll answer to only technical part. This patch creates different name
>  > internally, without renaming dcache. Are you really sure if that's ok?
>
> The name handling should be the same as the existing code path where
> goto shortname is done after vfat_create_shortname() in
> vfat_build_slots() (ie. when the name conformed to 8.3).
>
> What situation are you thinking of which this would cause a problem?

At this answer, I was missing the (is_shortname == 0).

However, if filename contains the chars in vfat_replace_char(). It will
have similar problem. In this case, this patch creates the dir entry
without longname. So, it wouldn't match to dcache and real dir entries.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/