[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8763gj7m23.fsf@devron.myhome.or.jp>
Date: Sat, 02 May 2009 20:59:16 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: tridge@...ba.org
Cc: Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
Steve French <sfrench@...ibm.com>,
Mingming Cao <cmm@...ibm.com>,
Paul McKenney <paulmck@...ux.vnet.ibm.com>,
LKML <linux-kernel@...r.kernel.org>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES option
tridge@...ba.org writes:
> > Yes. I guess -ENAMETOOLONG would not good for !valid, and !(is_shortname
> > && base_info.valid && ext_info.valid) or add "else" part is more prefer
> > though.
>
> ok, new patch below.
Looks good to me as technical stand.
> > Yes. The case-insensitive is ok, the dcache can handle case-insensitive.
>
> good, that makes life simpler :-)
>
> Are you happy with the shortname_flags hackery in
> vfat_create_shortname() ?
Ah. What is the intent to force WINNT option (lcase field)? To force it
may not be good. So, change default if config is on?
--
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists