[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0905031603150.32125@blonde.anvils>
Date: Sun, 3 May 2009 16:05:08 +0100 (BST)
From: Hugh Dickins <hugh@...itas.com>
To: Matthew Wilcox <matthew@....cx>
cc: Matthew Wilcox <willy@...ux.intel.com>,
Boaz Harrosh <bharrosh@...asas.com>, linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org, Jeff Garzik <jgarzik@...hat.com>,
linux-scsi@...r.kernel.org, Jens Axboe <jens.axboe@...cle.com>,
Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
Mark Lord <lkml@....ca>
Subject: Re: New TRIM/UNMAP tree published (2009-05-02)
On Sun, 3 May 2009, Matthew Wilcox wrote:
>
> You make a good point. There's definitely still work to be done around
> error handling. OTOH, we could always do what IDE does ...
>
> static void idedisk_prepare_flush(struct request_queue *q, struct request *rq)
> {
> ide_drive_t *drive = q->queuedata;
> struct ide_cmd *cmd = kmalloc(sizeof(*cmd), GFP_ATOMIC);
>
> /* FIXME: map struct ide_taskfile on rq->cmd[] */
> BUG_ON(cmd == NULL);
Oooh, you're winding me up. Certainly not. Off with the Top Of your Head!
Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists