linux-kernel - Re: Lots of unexpected non-allocatable section warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090503202939.GA1237@uranus.ravnborg.org>
Date:	Sun, 3 May 2009 22:29:39 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Anders Kaseorg <andersk@....edu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Lots of unexpected non-allocatable section warnings

On Sun, May 03, 2009 at 08:03:32PM +0200, Sam Ravnborg wrote:
> > > 
> > > Cannot reproduce here..
> > 
> > Given the name of the section, I presume it is somewhat SUSE-specific.
> > I'm running openSUSE 11.1.
> Likely - I could not reprodcue with your config.
> 
> > > Can you send me your config so I can try to see if this is toolchain
> > > version related.
> > 
> > Config attached.
> > 
> > > Also what version of gcc/binutils are you using?
> > 
> > $ gcc --version
> > gcc (SUSE Linux) 4.3.2 [gcc-4_3-branch revision 141291]
> > 
> > $ ld -v
> > GNU ld (GNU Binutils; openSUSE 11.1) 2.19
> > 
> > > Is this x86 and 32/64 bit?
> > 
> > x86, 64 bit. If you need anything else, let me know.
> 
> Can you send me (off-list) the .o + .ko files
> for one of the failing modules.
> I like to see what the section contains - or at least the flags.
> I do not know on top of my head the commands so
> with the .o faile available I expect to figure it out.

Thanks for the .o file!

This is due to the SUSE specific section as you expected.
We ignore sections named ".comment" but not ".comment" sections
with something appended to the name.

Can you please try appended patch and let me know if it fixes it for you.

Thanks,
	Sam

>From 73aa9cbd4f71afdb173605383f77ebfda6d19ced Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <sam@...nborg.org>
Date: Sun, 3 May 2009 22:17:37 +0200
Subject: [PATCH 2/2] kbuild, modpost: fix "unexpected non-allocatable" warning with SUSE gcc

Jean reported that he saw one warning for each module like the one below:
WARNING: arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.o (.comment.SUSE.OPTs): unexpected non-allocatable section.

The warning appeared with the improved version of the
check of the flags in the sections.

That check already ignored sections named ".comment" - but SUSE store
additional info in the comment section and has named it in a SUSE
specific way. Therefore modpost failed to ignore the section.

The fix is to extend the pattern so we ignore all sections
that start with the name ".comment.".

Signed-off-by: Sam Ravnborg <sam@...nborg.org>
Reported-by: Jean Delvare <khali@...ux-fr.org>
---
 scripts/mod/modpost.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index a5c17db..268d457 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -727,7 +727,7 @@ int match(const char *sym, const char * const pat[])
 
 /* sections that we do not want to do full section mismatch check on */
 static const char *section_white_list[] =
-	{ ".comment", ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL };
+	{ ".comment*", ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL };
 
 /*
  * This is used to find sections missing the SHF_ALLOC flag.
-- 
1.6.3.rc3.40.g75b44

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/