linux-kernel - Re: [PATCH] export softirq_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090503083328.GC27707@elte.hu>
Date:	Sun, 3 May 2009 10:33:28 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jason Baron <jbaron@...hat.com>
Cc:	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	jistone@...hat.com
Subject: Re: [PATCH] export softirq_to_name symbol


* Jason Baron <jbaron@...hat.com> wrote:

> hi,
> 
> In response to a user request:
> 
> Export 'softirq_to_name' so that modules using the softirq 
> tracepoints can resolve the # to a name.
> 
> Signed-off-by: Jason Baron <jbaron@...hat.com>
> ---
>  kernel/softirq.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index b76064b..1841ab7 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -60,6 +60,7 @@ char *softirq_to_name[NR_SOFTIRQS] = {
>  	"HI", "TIMER", "NET_TX", "NET_RX", "BLOCK",
>  	"TASKLET", "SCHED", "HRTIMER",	"RCU"
>  };
> +EXPORT_SYMBOL_GPL(softirq_to_name);

Hm, that very much looks like as if someone was writing kernel 
tracing code without the intention to submitting it upstream. Not 
having exported that symbol is thus a subtle "dont do that please" 
warning sign ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/