linux-kernel - Re: [PATCH 2/2] mac80211: pid, fix memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1241453238.8683.52.camel@johannes.local>
Date:	Mon, 04 May 2009 18:07:17 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mac80211: pid, fix memory corruption

On Mon, 2009-05-04 at 18:04 +0200, Jiri Slaby wrote:

> +	for (i = 0; i < IEEE80211_NUM_BANDS; i++) {
> +		sband = hw->wiphy->bands[i];
> +		if (sband->n_bitrates > max_rates)
> +			max_rates = sband->n_bitrates;
> +	}
> +
>  	/* We can safely assume that sband won't change unless we get
>  	 * reinitialized. */
> -	rinfo = kmalloc(sizeof(*rinfo) * sband->n_bitrates, GFP_ATOMIC);
> +	rinfo = kmalloc(sizeof(*rinfo) * max_rates, GFP_ATOMIC);

I suppose you should remove the comment...

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)