linux-kernel - Re: [PATCH] input: Add support for the TSC2003 controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d5443650905041021n1f709ce1y382440d1285b09ec@mail.gmail.com>
Date:	Mon, 4 May 2009 22:51:21 +0530
From:	Trilok Soni <soni.trilok@...il.com>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	Kwangwoo Lee <kwangwoo.lee@...il.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] input: Add support for the TSC2003 controller.

Hi Therry,

On Mon, May 4, 2009 at 8:27 PM, Thierry Reding
<thierry.reding@...onic-design.de> wrote:
> * Trilok Soni wrote:
>> Hi Thierry,
>>
>> On Mon, May 4, 2009 at 5:07 PM, Thierry Reding
>> <thierry.reding@...onic-design.de> wrote:
>> > * Kwangwoo Lee wrote:
>> >> Hi Thierry and Trilok,
>> >>
>> >> On Wed, Apr 29, 2009 at 10:23 PM, Trilok Soni <soni.trilok@...il.com> wrote:
>> >> > Hi Thierry,
>> >> >
>> >> > I have added linux-omap community. How different is this chip from
>> >> > tsc2007. It looks to me that this chip is not much different from
>> >> > tsc2007 (this is just quick look at the driver). If they
>> >> > are similar please consider using i2c_device_id feature in tsc2007 to
>> >> > accommodate this chip.
>> >>
>> >> I agree with the Trilok's opinion.
>> > [snip]
>> >
>> > I only noticed the tsc2007 driver some time ago, when the tsc2003 was already
>> > finished (it's actually pretty old, I just never got around to submitting
>> > it). However I never got the tsc2007 to work on my platform because it uses
>> > sleeping functions inside the timer handler, which results in an oops right
>> > after the first touchscreen interrupt.
>> >
>> > I guess I could try and fix the tsc2007 properly instead of having a second,
>> > pretty similar driver in the tree.
>> >
>>
>> This could be because of improper locking? If you share a crash we can
>> have look at it.
>
> Attached is a patch that fixes things for me. The problem was that the I2C
> transfers were done in interrupt context which fails for the controller I use
> (PXA270). The attached patch uses a struct work_struct to schedule the I2C
> transfers so they are executed in non-interrupt context.
>
> I've tested the patch on a minimal system with tslib and it work fine with
> ts_calibrate and friends.

Thanks for the patch. It looks good. Let's wait for Kwangwoo Lee to
verify it on his platform. Also please add "tsc2003" entry into
i2c_device_ids so that i2c_board_info can specify the .name as
"tsc2003".

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/