linux-kernel - Re: compat ioctl32 for /dev/snapshot?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905042358.56943.rjw@sisk.pl>
Date:	Mon, 4 May 2009 23:58:56 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	"Linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: compat ioctl32 for /dev/snapshot?

On Monday 04 May 2009, Michael Tokarev wrote:
> Is there any reason why 32-bit uswsusp &Friends does not work
> on 64bits kernel?
> 
> For one, 32bits s2disk produces the following when trying to
> suspend:
> 
>   ioctl32(s2disk:4134): Unknown cmd fd(4) cmd(400c330d){t:'3';sz:12} arg(ff853554) on /dev/snapshot
>   ioctl32(s2disk:4134): Unknown cmd fd(4) cmd(4004330a){t:'3';sz:4} arg(00000805) on /dev/snapshot
> 
> this is coming from:
> 
>      error = ioctl(dev, SNAPSHOT_SET_SWAP_AREA, &swap);
>      if (error && !offset)
>              error = ioctl(dev, SNAPSHOT_SET_SWAP_FILE, blkdev);
> 
> but I guess (just guess!) that other SNAPSHOT_* operations will
> also fail the same way.
> 
> Is there a reason why those are not in compat_ioctl?

The user land hasn't been designed with that in mind.  You'd most likely have
to modify it too.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/