linux-kernel - Re: [PATCH] staging: &&/|| typo?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090504160421.555dbb67.akpm@linux-foundation.org>
Date:	Mon, 4 May 2009 16:04:21 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: &&/|| typo?

On Sat, 02 May 2009 22:46:47 +0200
Roel Kluin <roel.kluin@...il.com> wrote:

> Subject: [PATCH] staging: &&/|| typo?

nit: if/when this driver gets moved out of staging/, it will still have
a commit titled "staging: &&/|| typo?" in its record.

That title will be pretty useless and meaningless for a driver which
isn't in staging!

So I'd suggest that in general, the "staging" information be included
inside [], so it gets tossed away as the patch is applied.

Also, the title is pretty bad in other ways - it doesn't identify what
part of the kernel is being changed.  At least, not with sufficient
specificity.

So a better title would be, say,

	[patch] [staging] wis-sony-tuner.c: fix &&/|| error

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/