linux-kernel - Re: [PATCH] Fix early panic issue on machines with memless node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0905051336110.22577@chino.kir.corp.google.com>
Date:	Tue, 5 May 2009 13:41:23 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Jack Steiner <steiner@....com>
cc:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>, alex.shi@...el.com,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] Fix early panic issue on machines with memless node

On Tue, 5 May 2009, Jack Steiner wrote:

> I suspect I mislead you when I mentioned "configurations". I did not mean
> the .config file. I use a more-or-less standard .config file.
> 

Your .config would still let me build a kernel with debugging symbols so 
that your offsets actually made sense to my gdb.

> I do much of my testing on a system simulator. Using a simulator config file,
> I specify the system configuration such as number of nodes, sockets per node,
> cpus per socket, memory per socket, address map, boot options, etc. This
> makes it easy to quickly test a lot of strange (but real) configurations.
> 
> The configuration above that is failing is a 2-socket Nehelem blade that has no
> memory on socket 0. All memory is located on socket 1.  The panic is caused by a
> null dereference of NODE_DATA(0).
> 

A NULL dereference of NODE_DATA(0) should never happen even with 
!CONFIG_NEED_MULTIPLE_NODES.  So when you say the panic is caused by that 
(and I'm speculating since all I've seen is a call trace and not the 
entire panic), I'm assuming it's because NODE_DATA(0)->node_zones + offset 
is NULL because node 0 has no memory?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/