linux-kernel - Re: [PATCH] vmscan: ZVC updates in shrink_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2009 11:46:10 +0900
From:	Minchan Kim <barrioskmc@...il.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"cl@...ux-foundation.org" <cl@...ux-foundation.org>,
	"kosaki.motohiro@...fujitsu.com" <kosaki.motohiro@...fujitsu.com>,
	"npiggin@...e.de" <npiggin@...e.de>,
	"riel@...hat.com" <riel@...hat.com>, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vmscan: ZVC updates in shrink_active_list() can be done 
	once

Reviewed-by: Minchan Kim <minchan.kim@...il.com>

This fine-grained ZVC update in shrink_active_list was made for
determination problem of the dirty
ratio(c878538598d1e7ab41ecc0de8894e34e2fdef630).
The 32 page reclaim time in normal reclaim situation is too short to
change current VM behavior.
So I think this make sense to me.

On Tue, May 5, 2009 at 8:44 AM, Wu Fengguang <fengguang.wu@...el.com> wrote:
> This effectively lifts the unit of nr_inactive_* and pgdeactivate updates
> from PAGEVEC_SIZE=14 to SWAP_CLUSTER_MAX=32.
>
> Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> ---
>  mm/vmscan.c |   11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>
> --- linux.orig/mm/vmscan.c
> +++ linux/mm/vmscan.c
> @@ -1228,7 +1228,6 @@ static void shrink_active_list(unsigned
>                        struct scan_control *sc, int priority, int file)
>  {
>        unsigned long pgmoved;
> -       int pgdeactivate = 0;
>        unsigned long pgscanned;
>        LIST_HEAD(l_hold);      /* The pages which were snipped off */
>        LIST_HEAD(l_inactive);
> @@ -1257,7 +1256,7 @@ static void shrink_active_list(unsigned
>                __mod_zone_page_state(zone, NR_ACTIVE_ANON, -pgmoved);
>        spin_unlock_irq(&zone->lru_lock);
>
> -       pgmoved = 0;
> +       pgmoved = 0;  /* count referenced (mapping) mapped pages */
>        while (!list_empty(&l_hold)) {
>                cond_resched();
>                page = lru_to_page(&l_hold);
> @@ -1291,7 +1290,7 @@ static void shrink_active_list(unsigned
>         */
>        reclaim_stat->recent_rotated[!!file] += pgmoved;
>
> -       pgmoved = 0;
> +       pgmoved = 0;  /* count pages moved to inactive list */
>        while (!list_empty(&l_inactive)) {
>                page = lru_to_page(&l_inactive);
>                prefetchw_prev_lru_page(page, &l_inactive, flags);
> @@ -1304,10 +1303,7 @@ static void shrink_active_list(unsigned
>                mem_cgroup_add_lru_list(page, lru);
>                pgmoved++;
>                if (!pagevec_add(&pvec, page)) {
> -                       __mod_zone_page_state(zone, NR_LRU_BASE + lru, pgmoved);
>                        spin_unlock_irq(&zone->lru_lock);
> -                       pgdeactivate += pgmoved;
> -                       pgmoved = 0;
>                        if (buffer_heads_over_limit)
>                                pagevec_strip(&pvec);
>                        __pagevec_release(&pvec);
> @@ -1315,9 +1311,8 @@ static void shrink_active_list(unsigned
>                }
>        }
>        __mod_zone_page_state(zone, NR_LRU_BASE + lru, pgmoved);
> -       pgdeactivate += pgmoved;
>        __count_zone_vm_events(PGREFILL, zone, pgscanned);
> -       __count_vm_events(PGDEACTIVATE, pgdeactivate);
> +       __count_vm_events(PGDEACTIVATE, pgmoved);
>        spin_unlock_irq(&zone->lru_lock);
>        if (buffer_heads_over_limit)
>                pagevec_strip(&pvec);
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>



-- 
Thanks,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/