linux-kernel - Re: DMA debug trace pointing to rtl8187

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090506064513.GA7460@kroah.com>
Date:	Tue, 5 May 2009 23:45:13 -0700
From:	Greg KH <greg@...ah.com>
To:	Eric Valette <eric.valette@...e.fr>,
	Larry Finger <Larry.Finger@...inger.net>
Cc:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: DMA debug trace pointing to rtl8187

On Wed, May 06, 2009 at 08:35:52AM +0200, Eric Valette wrote:
> FUJITA Tomonori wrote:
> > CC'ed linux-usb,
> > 
> > The ehci_hcd driver uses buffers on the stack for DMA?
> > 
> > On Sun, 03 May 2009 17:36:24 +0200
> > Eric Valette <eric.valette@...e.fr> wrote:
> > 
> >> ------------[ cut here ]------------
> >>
> >> WARNING: at /usr/src/linux-2.6.22.9/lib/dma-debug.c:609
> > 
> > Hmm, the kernel version is wired. lib/dma-debug.c was added in
> > 2.6.30-rc.
> 
> No that's the file path.  I use ketchup to apply patches...
> 
> > 
> >> check_for_stack+0x6b/0x8b()
> >> Hardware name: P5W DH Deluxe
> >>
> >> ehci_hcd 0000:00:1d.7: DMA-API: device driver maps memory fromstack
> >> [addr=ffff88007fa79968]
> >> Modules linked in:
> >>
> >> Pid: 297, comm: khubd Not tainted 2.6.30-rc4-git1 #32
> 
> Here is the real version.

The problem is in the rtl8187 driver.

They are calling usb_control_msg and passing a pointer to a buffer on
the stack.  See drivers/net/wireless/rtl818x/rtl8187.h for where the
problem happens in numerous places.

Also it looks like rtl8225_write_8051() is incorrect.  You are passing a
pointer to a variable that was passed as an argument.  I don't know
where that is supposed to be on, somewhere on the stack I guess.

Larry, care to fix this up?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/