linux-kernel - Re: [PATCH 2/3] ptrace: cleanup check/set of PT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090506074421.GE17457@elte.hu>
Date:	Wed, 6 May 2009 09:44:21 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ptrace: cleanup check/set of PT_PTRACED during
	attach


* Oleg Nesterov <oleg@...hat.com> wrote:

> ptrace_attach() and ptrace_traceme() are the last functions which 
> look as if the untraced task can have task->ptrace != 0, this must 
> not be possible. Change the code to just check ->ptrace != 0 and 
> s/|=/=/ to set PT_PTRACED.
> 
> Also, a couple of trivial whitespace cleanups in ptrace_attach().
> 
> And move ptrace_traceme() up near ptrace_attach() to keep them 
> close to each other.

btw., while at it, please also fix the typos in 
include/linux/ptrace.h's PT_* flags section:

/*
 * Ptrace flags
 *
 * The owner ship rules for task->ptrace which holds the ptrace
 * flags is simple.  When a task is running it owns it's task->ptrace
 * flags.  When the a task is stopped the ptracer owns task->ptrace.
 */

s/owner ship/ownership
s/it's/its

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/