linux-kernel - Re: [PATCH 10/11] ring-buffer: move big if statement down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090506082447.GA28675@elte.hu>
Date:	Wed, 6 May 2009 10:24:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 10/11] ring-buffer: move big if statement down


* Steven Rostedt <rostedt@...dmis.org> wrote:

> This patch changes it to a goto:
> 
> 	code;
> 
> 	if (cross to next page)
> 		goto next_page;
> 
> 	more code;
> 
> 	return;
> 
> next_page:
> 
> 	[ lots of code]

I have pulled it, but could you please change it to a helper 
function instead? There's almost never a good reason to combine 
'more code' with 'lots of code' in a single function. It also 
documents the unlikeliness, etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/