linux-kernel - Re: [PATCH 1/3] ptrace: ptrace_attach: check PF_KTHREAD + exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090506020223.A4F1AFC328@magilla.sf.frob.com>
Date:	Tue,  5 May 2009 19:02:23 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Wright <chrisw@...s-sol.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ptrace: ptrace_attach: check PF_KTHREAD + exit_state
	instead of ->mm

This changes the order of the already-traced and security checks.
It would match the previous behavior to have the ->exit_state and ->ptrace
checks before __ptrace_may_access().  This is a small nit, but it could
affect whether some existing harmless usage pattern starts generating new
access failure logging from security modules (e.g. SELinux avc denials).

I don't see any reason you can't just swap the order back as it was before.
If you do that,
Acked-by: Roland McGrath <roland@...hat.com>

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/