[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090506173048.0ad84f85@pedra.chehab.org>
Date: Wed, 6 May 2009 17:30:48 -0300
From: Mauro Carvalho Chehab <mchehab@...hat.com>
To: Alan Cox <alan@...rguk.ukuu.org.uk>
Cc: torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dereferencing freed in saa5246a.c
Em Wed, 06 May 2009 17:13:33 +0100
Alan Cox <alan@...rguk.ukuu.org.uk> escreveu:
> From: Dan Carpenter <error27@...il.com>
>
> I lowered the kfree(t) down a couple lines and removed the superflous
> "t->vdev = NULL;"
>
> regards,
> dan carpenter
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
Acked-by: Mauro Carvalho Chehab <mchehab@...hat.com>
> ---
>
> drivers/media/video/saa5246a.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c
> index da47b2f..155804b 100644
> --- a/drivers/media/video/saa5246a.c
> +++ b/drivers/media/video/saa5246a.c
> @@ -1092,9 +1092,8 @@ static int saa5246a_probe(struct i2c_client *client,
> /* Register it */
> err = video_register_device(t->vdev, VFL_TYPE_VTX, -1);
> if (err < 0) {
> - kfree(t);
> video_device_release(t->vdev);
> - t->vdev = NULL;
> + kfree(t);
> return err;
> }
> return 0;
>
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists