linux-kernel - Re: [PATCH 1/4] tracing/events: don't say hi when loading the trace event sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0905052240570.3239@gandalf.stny.rr.com>
Date:	Tue, 5 May 2009 22:41:17 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Li Zefan <lizf@...fujitsu.com>
cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] tracing/events: don't say hi when loading the trace
 event sample


On Wed, 6 May 2009, Li Zefan wrote:

> The sample is useful for testing, and I'm using it. But after
> loading the module, it keeps saying hi every 10 seconds, this may
> be disturbing.
> 
> Also Steven said commenting out the "hi" helped in causing races. :)
> 
> [ Impact: make testing a bit easier ]
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> ---
>  samples/trace_events/trace-events-sample.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/samples/trace_events/trace-events-sample.c b/samples/trace_events/trace-events-sample.c
> index f33b3ba..aabc4e9 100644
> --- a/samples/trace_events/trace-events-sample.c
> +++ b/samples/trace_events/trace-events-sample.c
> @@ -16,10 +16,6 @@ static void simple_thread_func(int cnt)
>  	set_current_state(TASK_INTERRUPTIBLE);
>  	schedule_timeout(HZ);
>  	trace_foo_bar("hello", cnt);
> -
> -	if (!(cnt % 10))
> -		/* It is really important that I say "hi!" */

I guess it is not so important to say hi after all.

-- Steve

> -		printk(KERN_EMERG "hi!\n");
>  }
>  
>  static int simple_thread(void *arg)
> -- 
> 1.5.4.rc3
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/