linux-kernel - Re: [PATCH 3/10] scsi: megaraid_sas - Add Poll Wait mechanism to MegaRAID SAS driver (PART-II)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090506141904.15f70697.akpm@linux-foundation.org>
Date:	Wed, 6 May 2009 14:19:04 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Yang, Bo" <Bo.Yang@....com>
Cc:	Bo.Yang@....com, James.Bottomley@...senPartnership.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Winston.Austria@....com
Subject: Re: [PATCH 3/10] scsi: megaraid_sas - Add Poll Wait mechanism to
 MegaRAID SAS driver (PART-II)

On Tue, 5 May 2009 18:41:45 -0600
"Yang, Bo" <Bo.Yang@....com> wrote:

> @@ -3645,6 +3657,12 @@ static int __init megasas_init(void)
>                                   &driver_attr_release_date);
>         if (rval)
>                 goto err_dcf_rel_date;
> +
> +       rval = driver_create_file(&megasas_pci_driver.driver,
> +                               &driver_attr_support_poll_for_event);
> +       if (rval)
> +               goto err_dcf_support_poll_for_event;

This goto will be taken if the file wasn't successfully added.

>         rval = driver_create_file(&megasas_pci_driver.driver,
>                                   &driver_attr_dbg_lvl);
>         if (rval)
> @@ -3662,6 +3680,11 @@ err_dcf_poll_mode_io:
>  err_dcf_dbg_lvl:
>         driver_remove_file(&megasas_pci_driver.driver,
>                            &driver_attr_release_date);
> +
> +err_dcf_support_poll_for_event:
> +       driver_remove_file(&megasas_pci_driver.driver,
> +                       &driver_attr_support_poll_for_event);

And we then try to remove something which isn't there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/