linux-kernel - Re: [patch 57/58] tracing: x86, mmiotrace: fix range test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0905061812050.24643@gandalf.stny.rr.com>
Date:	Wed, 6 May 2009 18:12:24 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Greg KH <gregkh@...e.de>
cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>, Willy Tarreau <w@....eu>,
	Rodrigo Rubira Branco <rbranco@...checkpoint.com>,
	Jake Edge <jake@....net>, Eugene Teo <eteo@...hat.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Stuart Bennett <stuart@...edesktop.org>,
	Pekka Paalanen <pq@....fi>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [patch 57/58] tracing: x86, mmiotrace: fix range test


On Wed, 6 May 2009, Greg KH wrote:

> 2.6.29-stable review patch.  If anyone has any objections, please let us know.
> 
> ------------------
> 
> From: Stuart Bennett <stuart@...edesktop.org>
> 
> commit 33015c85995716d03f6293346cf05a1908b0fb9a upstream.
> 
> Matching on (addr == (p->addr + p->len)) causes problems when mappings
> are adjacent.
> 
> [ Impact: fix mmiotrace confusion on adjacent iomaps ]
> 
> Signed-off-by: Stuart Bennett <stuart@...edesktop.org>
> Acked-by: Pekka Paalanen <pq@....fi>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> LKML-Reference: <1240946271-7083-2-git-send-email-stuart@...edesktop.org>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> 
> ---
>  arch/x86/mm/kmmio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/mm/kmmio.c
> +++ b/arch/x86/mm/kmmio.c
> @@ -87,7 +87,7 @@ static struct kmmio_probe *get_kmmio_pro
>  {
>  	struct kmmio_probe *p;
>  	list_for_each_entry_rcu(p, &kmmio_probes, list) {
> -		if (addr >= p->addr && addr <= (p->addr + p->len))
> +		if (addr >= p->addr && addr < (p->addr + p->len))
>  			return p;
>  	}
>  	return NULL;
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/