linux-kernel - Re: [RFC PATCH 3/3a] ptrace: add _ptrace_may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090507092009.GC3036@sequoia.sous-sol.org>
Date:	Thu, 7 May 2009 02:20:09 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Chris Wright <chrisw@...s-sol.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [RFC PATCH 3/3a] ptrace: add _ptrace_may_access()

* Ingo Molnar (mingo@...e.hu) wrote:
> 
> * Chris Wright <chrisw@...s-sol.org> wrote:
> 
> > * Ingo Molnar (mingo@...e.hu) wrote:
> > > * Oleg Nesterov <oleg@...hat.com> wrote:
> > > > Agreed, but what about security_operations->ptrace_may_access ?
> > > > It has the same (bad) name, but returns the error code or 0 on 
> > > > success.
> > > 
> > > Bad code should generally be fixed, or in exceptional circumstances 
> > > it can tolerated if it's pre-existing bad code, but it should never 
> > > be propagated. It has not spread _that_ widely yet, and is isolated 
> > > to the security subsystem:
> > 
> > And the security hooks tend to all follow the 0 success -ve ERR on error.
> 
> I just sent a patch (see below) that renames them to 
> ptrace_access_check().
> 
> They have no active connection to the core kernel 
> ptrace_may_access() check in any case:

Not sure what you mean:

ptrace_may_access
 __ptrace_may_access
  security_ptrace_may_access

Looks like your patch won't compile.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/