linux-kernel - Re: [PATCH 3/5] tracing/events: add rcu locking around trace event prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0905070909020.32734@gandalf.stny.rr.com>
Date:	Thu, 7 May 2009 09:10:29 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	linux-kernel@...r.kernel.org,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/5] tracing/events: add rcu locking around trace event
 prints


On Thu, 7 May 2009, Ingo Molnar wrote:

> 
> * Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > Somehow this patch got dropped. I believe Ted's work requires it.
> > 
> > I'm not sure if we need to include rcupdate.h or not to use 
> > rcu_read_lock. I think it may be fine to include it in ftrace.h. 
> > 
> > Jeremy, does this patch effect anything that you are doing?
> > 
> > >  									\
> > > +	rcu_read_lock();						\
> > >  	ret = trace_seq_printf(s, #call ": " print);			\
> > > +	rcu_read_unlock();						\
> > >  	if (!ret)							\
> > >  		return TRACE_TYPE_PARTIAL_LINE;				\
> 
> Hm, this patch adds usage for RCU primitives, but doesnt include 
> rcupdate.h.

Yeah, I thought that would be an issue. Including rcupdate here should not 
be an issue, since the ftrace.h file is only included once, and the 
CREATE_TRACE_POINTS is already undefined.

I'll write up a new patch.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/