linux-kernel - Re: [PATCH] PM: suspend_device_irqs(): don't disable wakeup IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6200be20905061844q8a4945y83daa86b336dc49a@mail.gmail.com>
Date:	Wed, 6 May 2009 18:44:01 -0700
From:	Arve Hjønnevåg <arve@...roid.com>
To:	Kim Kyuwon <chammoru@...il.com>
Cc:	Kevin Hilman <khilman@...prootsystems.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] PM: suspend_device_irqs(): don't disable wakeup IRQs

2009/5/6 Kim Kyuwon <chammoru@...il.com>:
> 2009/5/7 Arve Hjønnevåg <arve@...roid.com>:
>> On Wed, May 6, 2009 at 5:16 PM, Kevin Hilman
>> <khilman@...prootsystems.com> wrote:
>>> "Rafael J. Wysocki" <rjw@...k.pl> writes:
>>>
>>>> On Wednesday 06 May 2009, Kevin Hilman wrote:
>>>>> Kevin Hilman <khilman@...prootsystems.com> writes:
>>
>>> There is at least one problem with that which is why Kyuwon Kim added
>>> the ->disable hook to OMAP's irq_chip.  The problem is with drivers
>>> that call disable_irq() in their suspend hook, usually done to prevent
>>> the device from waking the system since on OMAP, any IRQ can be
>>> configured to wake the system.
>>>
>>
>> This does not sound correct. disable_irq_wake should be used for this.
>> A driver may need to mask its interrupt before suspending but this
>> should not also disable it as a wakeup source.
>
> I wish I could use disable_irq_wake(), but it doesn't work in OMAP.

This does not sound like a hardware problem.

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/