linux-kernel - Re: [v0 PATCH 1/1] Use dev_name() for AMD8111/AMD8131 EDAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090507145722.b2d89e11.akpm@linux-foundation.org>
Date:	Thu, 7 May 2009 14:57:22 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Harry Ciao <qingtao.cao@...driver.com>
Cc:	norsk5@...oo.com, bluesmoke-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [v0 PATCH 1/1] Use dev_name() for AMD8111/AMD8131 EDAC driver

On Thu,  7 May 2009 09:47:38 +0800
Harry Ciao <qingtao.cao@...driver.com> wrote:

> The device structure no longer has bus_id member, dev_name() should
> be used for AMD8111 & AMD8131 EDAC driver instead. Also, their Makefile 
> entries are lost, add them.
> 
> Signed-off-by: Harry Ciao <qingtao.cao@...driver.com>
> ---
>  drivers/edac/Makefile       |    2 ++
>  drivers/edac/amd8111_edac.c |    4 ++--
>  drivers/edac/amd8131_edac.c |    2 +-
>  3 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> index a5fdcf0..5907681 100644
> --- a/drivers/edac/Makefile
> +++ b/drivers/edac/Makefile
> @@ -35,3 +35,5 @@ obj-$(CONFIG_EDAC_MPC85XX)		+= mpc85xx_edac.o
>  obj-$(CONFIG_EDAC_MV64X60)		+= mv64x60_edac.o
>  obj-$(CONFIG_EDAC_CELL)			+= cell_edac.o
>  obj-$(CONFIG_EDAC_PPC4XX)		+= ppc4xx_edac.o
> +obj-$(CONFIG_EDAC_AMD8111)		+= amd8111_edac.o
> +obj-$(CONFIG_EDAC_AMD8131)		+= amd8131_edac.o

hm, I wonder how that happened.

The drivers break x86-64 allmodconfig:

drivers/edac/amd8111_edac.c: In function 'amd8111_lpc_bridge_init':
drivers/edac/amd8111_edac.c:260: error: implicit declaration of function '__do_inb'
drivers/edac/amd8111_edac.c:274: error: implicit declaration of function '__do_outb'

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/