linux-kernel - issue with epoll syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d51f89b0905072106q6f4c3eb8n663798c485f2ec44@mail.gmail.com>
Date:	Fri, 8 May 2009 09:36:52 +0530
From:	rohit verma <rohit.170309@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: issue with epoll syscall

hi all,

The man pages of epoll_create says - "Since Linux 2.6.8, the size
argument is unused.  (The kernel dynamically sizes the required data
structures without needing this initial hint.)" .

Also, it says that the syscall returns EINVAL , when size is not
positive. (i.e For, any value greater than 0, the kernel dynamically
sizes the required data stuctures). When size is zero or less than
zero, it has to return with error as EINVAL.

the latest patch of the epoll syscall tells:

asmlinkage long sys_epoll_create(int size)
{
- return sys_epoll_create2(size,0);
+ if (size < 0)
+  return -EINVAL;
+
+return sys_epoll_create1(0);
}

So if size = 0, it returns success which might not be the expected
result. So i feel that the condition check should be
" if (size <= 0) ". could u please check on this and reply me..

Thank you,

Regards,
rohit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/