linux-kernel - Re: [PATCH] deal with interrupt shadow state for emulated instruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090508071814.GC25357@redhat.com>
Date:	Fri, 8 May 2009 10:18:14 +0300
From:	Gleb Natapov <gleb@...hat.com>
To:	Glauber Costa <glommer@...hat.com>
Cc:	Avi Kivity <avi@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] deal with interrupt shadow state for emulated
	instruction

On Fri, May 08, 2009 at 02:25:11AM -0300, Glauber Costa wrote:
> On Wed, May 06, 2009 at 01:51:04PM +0300, Avi Kivity wrote:
> > Gleb Natapov wrote:
> >> On Tue, May 05, 2009 at 02:40:11PM -0400, Glauber Costa wrote:
> >>   
> >>> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> >>> index 8e680c3..a49d07b 100644
> >>> --- a/arch/x86/include/asm/kvm_host.h
> >>> +++ b/arch/x86/include/asm/kvm_host.h
> >>> @@ -510,6 +510,8 @@ struct kvm_x86_ops {
> >>>  	void (*run)(struct kvm_vcpu *vcpu, struct kvm_run *run);
> >>>  	int (*handle_exit)(struct kvm_run *run, struct kvm_vcpu *vcpu);
> >>>  	void (*skip_emulated_instruction)(struct kvm_vcpu *vcpu);
> >>> +	void (*set_interrupt_shadow)(struct kvm_vcpu *vcpu, int mask);
> >>>     
> >> There is .drop_interrupt_shadow() callback. The patch should remove it and
> >> replace its use by set_interrupt_shadow().
> >>   
> >
> > That would be [PATCH 1/2].
> [PATCH 2/2]. Otherwise we will break bisectability, as the pure removal of this
> function would lead us to a non-functioning kernel for no reason.
> 
> Avi: if this patch is okay, please apply. I'll send another one later that replaces
> the existing .drop_interrupt_shadow by the (then) in tree set_interrupt_shadow.
> 
It is not always easy to understand what Avi means :) but my
interpretation was that patch 1/2 should replace drop_interrupt_shadow()
with set_interrupt_shadow() and 2/2 should be only emulation changes.

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/