linux-kernel - Re: [PATCH 05/16] xen mtrr: Add mtrr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090508111703.GG11596@elte.hu>
Date:	Fri, 8 May 2009 13:17:03 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Yinghai Lu <yinghai@...nel.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>
Cc:	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Stephen Tweedie <sct@...hat.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
Subject: Re: [PATCH 05/16] xen mtrr: Add mtrr_ops support for Xen mtrr


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> +/* DOM0 TODO: Need to fill in the remaining mtrr methods to have full
> + * working userland mtrr support. */
> +static struct mtrr_ops xen_mtrr_ops = {
> +	.vendor            = X86_VENDOR_UNKNOWN,
> +//	.set               = xen_set_mtrr,
> +//	.get               = xen_get_mtrr,
> +	.get_free_region   = generic_get_free_region,
> +//	.validate_add_page = xen_validate_add_page,
> +	.have_wrcomb       = positive_have_wrcomb,
> +	.use_intel_if	   = 0,
> +	.num_var_ranges	   = xen_num_var_ranges,
> +};

Please dont post patches with ugly TODO items in them.

Also, a more general objection is that /proc/mtrr is a legacy 
interface, we dont really want to extend its use. The Xen hypervisor 
should get proper PAT support instead ...

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/