linux-kernel - Re: INET_LRO as tristate and use from modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090508.124347.142493836.davem@davemloft.net>
Date:	Fri, 08 May 2009 12:43:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	olof@...om.net
Cc:	subrata@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	geoffrey.levand@...sony.com, Linuxppc-dev@...abs.org,
	sfr@...b.auug.org.au, linux-next@...r.kernel.org,
	sachinp@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	themann@...ibm.com
Subject: Re: INET_LRO as tristate and use from modules

From: David Miller <davem@...emloft.net>
Date: Wed, 22 Apr 2009 02:12:18 -0700 (PDT)

> From: Olof Johansson <olof@...om.net>
> Date: Tue, 21 Apr 2009 14:33:19 -0500
> 
>> On Wed, Apr 22, 2009 at 12:23:03AM +0530, Subrata Modak wrote:
>>>   MODPOST 338 modules
>>> ERROR: ".lro_receive_skb" [drivers/net/pasemi_mac_driver.ko] undefined!
>>> ERROR: ".lro_flush_all" [drivers/net/pasemi_mac_driver.ko] undefined!
>>> WARNING: modpost: Found 1 section mismatch(es).
>>> To see full details build your kernel with:
>>> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>>> make[1]: *** [__modpost] Error 1
>>> make: *** [modules] Error 2
>> 
>> This seems to be a problem with all tristate-capable drivers that use
>> LRO (and uses select INET_LRO in their Kconfig): INET_LRO is a tristate
>> and can thus be a module. Looks like it needs to be a bool instead?
> 
> Yes, making this a bool would be the easiest fix.
> 
> By why don't we get the same problem for PHYLIB?  It's also
> tristate and "select"'d by a whole slew of networking drivers.

I guess nobody has any idea...

I'll just make INET_LRO a bool to fix this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/