linux-kernel - Re: [RFT] rtl8187: use DMA-aware buffers with usb_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A054F18.7020501@free.fr>
Date:	Sat, 09 May 2009 11:38:32 +0200
From:	Eric Valette <eric.valette@...e.fr>
To:	Hin-Tak Leung <hintak.leung@...il.com>,
	"John W. Linville" <linville@...driver.com>
CC:	linux-wireless@...r.kernel.org, Greg KH <greg@...ah.com>,
	Larry Finger <Larry.Finger@...inger.net>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [RFT] rtl8187: use DMA-aware buffers with usb_control_msg

Hin-Tak Leung wrote:
> On Wed, May 6, 2009 at 7:02 PM, John W. Linville <linville@...driver.com> wrote:
>> This definitely needs to fail more gracefully in the event of a
>> kmalloc failure...
>>
>> Signed-off-by: John W. Linville <linville@...driver.com>

OK guys. Thanks for your support and sorry for the delay: I add to
struggle with drm git to compile with 2.6.30-rc4-git3 (due to various
non yet integraed things my automated rebuild procedure does git fetch
for drm, xf86-video-nouveau, ...) , leading to no X server which for me
is more annoying than a trace in a USB wireless driver that I seldom use
only to test some new wireless feature (two GE port onboard).

The patch fix the DMA warning and the driver seems to work (just
associated it) but I must say that the allocation failure handling path
and the fact that we use now kmalloc for allocating a few bytes in such
a routine makes me worry about possible negative performance impact
unless theses routines are used only in a slow configuration path (did
no took time to red the code due to many other problems).

BTW if someone know who I should send this attached patch for DRM git, I
would gladly forward it.

-- eric

View attachment "patch-drm" of type "text/plain" (1174 bytes)