[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c62985530905090712l59de17fbh2085119f2574255a@mail.gmail.com>
Date: Sat, 9 May 2009 16:12:16 +0200
From: Frédéric Weisbecker <fweisbec@...il.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: Jason Baron <jbaron@...hat.com>, Tom Zanussi <tzanussi@...il.com>,
linux-kernel@...r.kernel.org, laijs@...fujitsu.com,
rostedt@...dmis.org, peterz@...radead.org,
mathieu.desnoyers@...ymtl.ca, jiayingz@...gle.com,
mbligh@...gle.com, roland@...hat.com, fche@...hat.com
Subject: Re: [RFC] convert ftrace syscall tracer to TRACE_EVENT()
Le 9 mai 2009 16:07, Ingo Molnar <mingo@...e.hu> a écrit :
>
> * Frédéric Weisbecker <fweisbec@...il.com> wrote:
>
>> > Note, this assumes that all syscall types can be described via
>> > __field() - i think that's correct. (we dont want to deref
>> > strings as they are untrusted, and there are no arrays in
>> > syscall parameters)
>>
>> Yeah, but we can also define a __string_from_user(), should be
>> trivial.
>
> We cannot really do that, because we cannot check the type in a
> macro. So we dont know when to inject __field() versus
> __string_from_user().
Aah...you're right :-/
>
>> > Can you see any complication?
>>
>> Just about the order of headers to include and headers
>> dependencies....
>
> That is testable and any problems will be found at the build stage,
> so it should be solvable.
>
> Ingo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists