linux-kernel - Re: [PATCH 2/5] introduce "struct wait_opts" to simplify do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090509161901.GB8150@redhat.com>
Date:	Sat, 9 May 2009 18:19:01 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Richard Kennedy <richard@....demon.co.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Roland McGrath <roland@...hat.com>,
	Vitaly Mayatskikh <vmayatsk@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] introduce "struct wait_opts" to simplify do_wait()
	pathes

sorry for delay Richard,

On 05/07, Richard Kennedy wrote:
>
> Oleg Nesterov wrote:
> >
> > +struct wait_opts {
> > +	enum pid_type		wo_type;
> > +	struct pid		*wo_pid;
> > +	int			wo_flags;
> > +
> > +	struct siginfo __user	*wo_info;
> > +	int __user		*wo_stat;
> > +	struct rusage __user	*wo_rusage;
> > +
> > +	int			notask_error;
> > +};
> > +
>
> Hi Oleg,
> you can remove 8 bytes of alignment padding from wait_opts on 64bit
> builds if you reorder it slightly.
>
> struct wait_opts {
> 	enum pid_type 	wo_type;
> 	int 		wo_flags;
> 	struct pid	*wo_pid;
> 	...

Thanks, didn't think about this...

This is already in -mm, perhaps you can send the patch to Andrew?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/