linux-kernel - [PATCH] pcf50633: Fix unsafe disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 09 May 2009 15:21:43 -0500
From:	Nelson Castillo <arhuaco@...aks-unidos.net>
To:	sameo@...ux.intel.com
Cc:	balajirrao@...nmoko.org, linux-kernel@...r.kernel.org
Subject: [PATCH] pcf50633: Fix unsafe disable_irq

Without this change Openmoko Freerunner (GTA02) bootstrap
will deadlock. As pointed out in other patches this issue is
in the wild since the merge of:

commit 3aa551c9b4c40018f0e261a178e3d25478dc04a9
Author: Thomas Gleixner <tglx@...utronix.de>
Date:   Mon Mar 23 18:28:15 2009 +0100

   genirq: add threaded interrupt handler support

   Add support for threaded interrupt handlers

Signed-off-by: Nelson Castillo <arhuaco@...aks-unidos.net>
---

 drivers/mfd/pcf50633-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 7793932..11a6248 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -443,7 +443,7 @@ static irqreturn_t pcf50633_irq(int irq, void *data)
 	dev_dbg(pcf->dev, "pcf50633_irq\n");
 
 	get_device(pcf->dev);
-	disable_irq(pcf->irq);
+	disable_irq_nosync(pcf->irq);
 	schedule_work(&pcf->irq_work);
 
 	return IRQ_HANDLED;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/