linux-kernel - Re: [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A04F5D7.2050909@gmail.com>
Date:	Fri, 08 May 2009 23:17:43 -0400
From:	Marc Dionne <marc.c.dionne@...il.com>
To:	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
CC:	Eric Paris <eparis@...hat.com>, Eric Paris <eparis@...isplace.org>,
	Christoph Hellwig <hch@....de>, Andrew Morton <akpm@...l.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, serue@...ibm.com,
	hpa@...or.com, sukadev@...ibm.com, linux-kernel@...r.kernel.org,
	jbacik@...hat.com
Subject: Re: [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts

On 05/07/2009 07:21 PM, Sukadev Bhattiprolu wrote:
> Er. I meant add following lines after the memset().
>
> |         opts->mode    = DEVPTS_DEFAULT_MODE;
> |         opts->ptmxmode = DEVPTS_DEFAULT_PTMX_MODE;

Adding those two lines (with . instead of ->) does fix the issue for me, 
thanks.

| > Of course we would still need to understand if/
| > why this patch changes the settings.

That particular patch changed things because the original memcpy in 
new_pts_mount() did this:

memcpy(&fsi->mount_opts, opts, sizeof(opts));

where opts was a pointer, not a structure.  So only the first few bytes 
of the blank opts actually got copied over.  The patch moved this memcpy 
to devpts_get_sb() and in the process fixed the sizeof error.

Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/