| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090509035401.GA8007@elte.hu> Date: Sat, 9 May 2009 05:54:01 +0200 From: Ingo Molnar <mingo@...e.hu> To: Alexey Dobriyan <adobriyan@...il.com> Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] groups: move code to kernel/groups.c * Alexey Dobriyan <adobriyan@...il.com> wrote: > Move supplementary groups implementation to kernel/groups.c . > kernel/sys.c already accumulated quite a few random stuff. > > Do strictly copy/paste + add required headers to compile. > Compile-tested on many configs and archs. > > Signed-off-by: Alexey Dobriyan <adobriyan@...il.com> > --- > > kernel/Makefile | 1 > kernel/groups.c | 288 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > kernel/sys.c | 283 ------------------------------------------------------- > 3 files changed, 289 insertions(+), 283 deletions(-) If you touch this code (which code has not been touched for years), do it only if you are also willing to do a followup patch that fixes most of these checkpatch warnings: total: 1 errors, 9 warnings, 0 checks, 584 lines checked (Most of these are valid - and there's some other low hanging fruits as well which you will notice if you read the file.) When creating a new file in kernel/ there's just no excuse for not doing it cleanly. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists